feat(text-input): form submission - #2647

🦋 Changeset detected

Latest commit: 3ec82a6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

✅ Deploy Preview for patternfly-elements ready!

To edit notification comments on pull requests, go to your Netlify site settings.

@bennypowers Should a form still be submitted if the required attribute is present on pf-text-input?

I added this code to the demo

<fieldset>
  <form id="pf-form">
    <legend>Text Input</legend>
    <label for="input">Input</label>
    <pf-text-input id="input" required></pf-text-input>
  </form>
</fieldset>

<script type="module">
  import '@patternfly/elements/pf-text-input/pf-text-input.js';

  const pfForm = document.querySelector('#pf-form');
  pfForm.addEventListener('submit', event => {
    event.preventDefault();

    console.log('pf-form submitted');
  });
</script>

<link rel="stylesheet" href="demo.css">

What I'm seeing is that event though the required attribute is present on pf-text-input, the form is still being submitted and the validation is not being caught.

@kylebuch8 https://deploy-preview-2647--patternfly-elements.netlify.app/components/text-input/demo/form-submission/

@bennypowers Very nice. Thanks.